skip pkg_test imports#13
Open
tgulacsi wants to merge 1 commit intorobertkrimen:masterfrom
tgulacsi:testpkg
Open
skip pkg_test imports#13tgulacsi wants to merge 1 commit intorobertkrimen:masterfrom tgulacsi:testpkg
tgulacsi wants to merge 1 commit intorobertkrimen:masterfrom
tgulacsi:testpkg
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example in
gopkg.in/rana/ora.v4, some tests are internal (package ora), some tests external (package ora_test). The latter results in wrong import path, and this is random, as it depends on which file was read first in the for cycle!This CL skips package names with
_testsuffix.